enhance: use more descriptive names for database tools #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
requested review from
ibuildthecloud,
cjellick,
drpebcak,
thedadams,
tybalex,
sanjay920,
StrongMonkey and
iwilltry42
njhale
added a commit
to njhale/obot
that referenced
this pull request
Jan 10, 2025
Depends on obot-platform/tools#334 Addresses part of obot-platform#1208 Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance/rename-database-exec
branch
from
b178ee0 to
d20beeb
Compare
thedadams
approved these changes
Jan 13, 2025
StrongMonkey
approved these changes
Jan 13, 2025
cjellick
reviewed
Jan 13, 2025
| Name: Tables | ||
| Description: List all tables in the SQLite database and return the results in markdown format | ||
| Name: List Tables | ||
| Description: List all tables in the SQLite database and return a JSON object containing the results |
There was a problem hiding this comment.
"the results in markdown format"
Just to double check - you didnt change the return format right? You are just updating the description to match reality?
There was a problem hiding this comment.
@cjellick Yes, I'm just updating it to match a change Darren made a while back. We were originally returning markdown formatted data. It's been JSON for a while at this point.
njhale
added a commit
to njhale/obot
that referenced
this pull request
Jan 13, 2025
Depends on obot-platform/tools#334 Addresses part of obot-platform#1208 Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance/rename-database-exec
branch
from
d20beeb to
63e4fd4
Compare
To reduce confusion in both the LLM and tool maintainers, rename the following tools in the `Database` bundle: 1. `Tables` -> `List Database Tables` 2. `Exec` -> `Exec Database Statement` 3. `Query` -> `Run Database Query` Also fix tool descriptions to reflect the change from raw markdown output to JSON. Addresses obot-platform/obot#1208 Since these tools are in the `Capability` category, the "blast radius" of this change includes [the `TableHandler` implementation in obot](https://github.com/obot-platform/obot/blob/31ceab62d455bd798a069be034ea8effb1b41ac4/ui/user/src/lib/components/navbar/Tables.svelte#L8) and all tools/agents currently using them. That being the case, we should hold-off on merging this change until the `TableHandler` implementation has been updated to the new tool names. I can also keep the old tools around until the handler implementation is updated. Signed-off-by: Nick Hale <[email protected]>
njhale
force-pushed
the
enhance/rename-database-exec
branch
from
63e4fd4 to
55d2fcd
Compare
njhale
added a commit
to obot-platform/obot
that referenced
this pull request
Jan 13, 2025
Depends on obot-platform/tools#334 Addresses part of #1208 Signed-off-by: Nick Hale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce confusion in both the LLM and tool maintainers, rename the following tools in the
Databasebundle:Tables->List Database TablesExec->Exec Database StatementQuery->Run Database QueryAlso fix tool descriptions to reflect the change from raw markdown output to JSON.
Addresses obot-platform/obot#1208
Since these tools are in the
Capabilitycategory, the "blast radius" of this change includes theTableHandlerimplementation in obot and all tools/agents currently using them. That being the case, weshould hold-off on merging this change until the
TableHandlerimplementation has been updated to the new tool names, or I keep duplicate tools that have the old names around until the handler implementation is updated.